sheetjs/sheetjs
36
Fork 37
Code Issues 193 Pull Requests 12 Wiki Activity

fix date/time rounding issue #2717

Open
scottysseus wants to merge 2 commits from scottysseus/2560_2 into master
pull from: scottysseus/2560_2
merge into: sheetjs:master
Conversation 5 Commits 2 Files Changed 6 +333 -140
scottysseus commented 2022-06-15 18:45:40 +00:00 (Migrated from github.com)
Copy Link

See: #2560

  • Improved rounding to account for minutes, hours, etc.
  • Added tests for rounding dates/times
See: #2560 - Improved rounding to account for minutes, hours, etc. - Added tests for rounding dates/times
SheetJSDev commented 2022-06-20 19:18:53 +00:00 (Migrated from github.com)
Copy Link

The tests predictably failed on old node versions since they did not support ES6 destructuring.

Did you test against the examples provided by @snoopyjc in https://github.com/SheetJS/sheetjs/issues/2560#issuecomment-1062838050 ?

The tests predictably failed on old node versions since they did not support ES6 destructuring. Did you test against the examples provided by @snoopyjc in https://github.com/SheetJS/sheetjs/issues/2560#issuecomment-1062838050 ?
scottysseus commented 2022-06-21 21:00:30 +00:00 (Migrated from github.com)
Copy Link

Thanks for the quick reply, @SheetJSDev. I have added @snoopyjc's test cases, and the syntax should be fully compatible with ES3 now.

Thanks for the quick reply, @SheetJSDev. I have added @snoopyjc's test cases, and the syntax should be fully compatible with ES3 now.
scottysseus commented 2022-07-13 13:47:19 +00:00 (Migrated from github.com)
Copy Link

@SheetJSDev I would like to get this change merged if there aren't any other issues and you think it's appropriate. Is there anything else I need to do?

@SheetJSDev I would like to get this change merged if there aren't any other issues and you think it's appropriate. Is there anything else I need to do?
SheetJSDev commented 2022-07-15 07:19:15 +00:00 (Migrated from github.com)
Copy Link

Nothing else on your end. There are some logistical issues we are figuring out regarding date handling.

Ideally, 0.19.0 resolves the outstanding date processing problems which requires both the SSF formatting library and the main file processing library to agree on date code interpretation.

Nothing else on your end. There are some logistical issues we are figuring out regarding date handling. Ideally, 0.19.0 resolves the outstanding date processing problems which requires both the SSF formatting library and the main file processing library to agree on date code interpretation.
MrToadie commented 2022-09-10 10:04:41 +00:00 (Migrated from github.com)
Copy Link

Thanks for all your work!

Thanks for all your work!
This pull request has changes conflicting with the target branch.
  • packages/ssf/bits/50_date.js
  • packages/ssf/bits/82_eval.js
  • packages/ssf/ssf.flow.js
  • packages/ssf/ssf.js
  • packages/ssf/test/date.js
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin scottysseus/2560_2:scottysseus/2560_2
git checkout scottysseus/2560_2

Merge

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff scottysseus/2560_2
git checkout master
git merge --ff-only scottysseus/2560_2
git checkout scottysseus/2560_2
git rebase master
git checkout master
git merge --no-ff scottysseus/2560_2
git checkout master
git merge --squash scottysseus/2560_2
git checkout master
git merge --ff-only scottysseus/2560_2
git checkout master
git merge scottysseus/2560_2
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
DBF

   
Dates

   
Defined Names

   
Features

   
Formula

   
HTML

   
Images

   
Infrastructure

   
Integration

   
International

   
ODS

   
Operations

   
Performance

   
PivotTables

   
Pro

   
Protection

   
Read Bug

   
SSF

   
SYLK

   
Style

   
Write Bug

   
good first issue
No Label
DBF
Dates
Defined Names
Features
Formula
HTML
Images
Infrastructure
Integration
International
ODS
Operations
Performance
PivotTables
Pro
Protection
Read Bug
SSF
SYLK
Style
Write Bug
good first issue
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/sheetjs#2717
No description provided.
Delete Branch "scottysseus/2560_2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?