sheetjs/sheetjs
41
Fork 43
Code Issues 201 Pull Requests 12 Wiki Activity

substr() doesn't work properly with IE8 #351

Closed
Aymkdn wants to merge 1 commits from patch-2 into master
pull from: patch-2
merge into: sheetjs:master
Conversation 1 Commits 1 Files Changed 1 +1 -1
Aymkdn commented 2016-01-13 18:03:11 +00:00 (Migrated from github.com)
Copy Link

Use slice() instead of substr() to make it work with IE8

Use slice() instead of substr() to make it work with IE8
SheetJSDev commented 2017-02-22 07:06:13 +00:00 (Migrated from github.com)
Copy Link

@Aymkdn all bad cases where substr was being used with a negative index were replaced with slice. This also resolved some IE6 issues with reading XLSB files!

@Aymkdn all bad cases where substr was being used with a negative index were replaced with slice. This also resolved some IE6 issues with reading XLSB files!

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
DBF

   
Dates

   
Defined Names

   
Features

   
Formula

   
HTML

   
Images

   
Infrastructure

   
Integration

   
International

   
ODS

   
Operations

   
Performance

   
PivotTables

   
Pro

   
Protection

   
Read Bug

   
SSF

   
SYLK

   
Style

   
Write Bug

   
good first issue
No Label
DBF
Dates
Defined Names
Features
Formula
HTML
Images
Infrastructure
Integration
International
ODS
Operations
Performance
PivotTables
Pro
Protection
Read Bug
SSF
SYLK
Style
Write Bug
good first issue
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/sheetjs#351
No description provided.
Delete Branch "patch-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?