Fix export of styled blank cells to JSON #354

2016-01-18T12:15:40Z

Martin-Pitt commented

2016-01-18 12:15:40 +00:00

(Migrated from github.com)

Here are two fixes that support the ability to export the cellStyles of blank cells into JSON.

One fix involves allowing cellStubs to exist in JSON. (90_utils.js:117)
Second fix involves formating cellStyles correctly on stub cells. (66_wscommon.js:38)

This is for reading files with cellStyles & sheetStubs both set and then trying to convert a worksheet with XLSX.utils.sheet_to_json.

I'm not an employee of Microsoft or signed any of their NDAs, etc.

This may be related to: https://github.com/SheetJS/js-xlsx/issues/333, https://github.com/SheetJS/js-xlsx/issues/50
I tried searching for other relevant issues but was unable to find them. I would have originally put the cellStyles as an issue but decided to go ahead and just simply fix it myself and do a pull request.

I haven't been able to run the tests, complains about some mocha thing. The changes are super simple though so I am sure that someone else could do some verification tests that have their environment already working and ready.

Here are two fixes that support the ability to export the cellStyles of blank cells into JSON. One fix involves allowing cellStubs to exist in JSON. (90_utils.js:117) Second fix involves formating cellStyles correctly on stub cells. (66_wscommon.js:38) This is for reading files with `cellStyles` & `sheetStubs` both set and then trying to convert a worksheet with `XLSX.utils.sheet_to_json`. I'm not an employee of Microsoft or signed any of their NDAs, etc. This may be related to: https://github.com/SheetJS/js-xlsx/issues/333, https://github.com/SheetJS/js-xlsx/issues/50 I tried searching for other relevant issues but was unable to find them. I would have originally put the cellStyles as an issue but decided to go ahead and just simply fix it myself and do a pull request. I haven't been able to run the tests, complains about some mocha thing. The changes are super simple though so I am sure that someone else could do some verification tests that have their environment already working and ready.

reviewher commented

2017-03-23 04:20:07 +00:00

(Migrated from github.com)

@Martin-Pitt the whole stub processing was revamped and I think the underlying issues were resolved.