resolved issue #582, to make method sheet_to_json options supported skipUndefined and defaultValue #583

Closed

jimjin wants to merge 0 commits from master into master

pull from: master

merge into: sheetjs:master

sheetjs:sankhavaramsaitulasiram/feat-fix-2752

sheetjs:maybeswapnil/issue2737

sheetjs:gh-pages

sheetjs:scottysseus/2560_2

sheetjs:ivan-trusov/fix-basedate

sheetjs:nandanv2702/issue_1300

sheetjs:protobi/master

sheetjs:ThomasChan/master

sheetjs:grantfayvor/master

sheetjs:tom-groves/bug-1105/rounding-error

sheetjs:mgreter/master

Conversation 11 Commits - Files Changed -

jimjin commented 2017-03-07 02:58:42 +00:00 (Migrated from github.com)

Copy Link

Add options for sheet_to_json method:

sheet_to_json({skipUndefined: false, defaultValue: null});
sheet_to_json({skipUndefined: false, defaultValue: ''});
sheet_to_json({skipUndefined: true});

Add options for sheet_to_json method: ``` sheet_to_json({skipUndefined: false, defaultValue: null}); sheet_to_json({skipUndefined: false, defaultValue: ''}); sheet_to_json({skipUndefined: true}); ```

coveralls commented 2017-03-07 03:27:45 +00:00 (Migrated from github.com)

Copy Link

Changes Unknown when pulling ee97102b54 on jimjin:master into ** on SheetJS:master**.

[](https://coveralls.io/builds/10464203) Changes Unknown when pulling **ee97102b5425b4153b7c41203b5fa3afb2b35f25 on jimjin:master** into ** on SheetJS:master**.

coveralls commented 2017-03-07 03:27:45 +00:00 (Migrated from github.com)

Copy Link

Changes Unknown when pulling ee97102b54 on jimjin:master into ** on SheetJS:master**.

[](https://coveralls.io/builds/10464203) Changes Unknown when pulling **ee97102b5425b4153b7c41203b5fa3afb2b35f25 on jimjin:master** into ** on SheetJS:master**.

coveralls commented 2017-03-07 03:27:45 +00:00 (Migrated from github.com)

Copy Link

Changes Unknown when pulling ee97102b54 on jimjin:master into ** on SheetJS:master**.

[](https://coveralls.io/builds/10464203) Changes Unknown when pulling **ee97102b5425b4153b7c41203b5fa3afb2b35f25 on jimjin:master** into ** on SheetJS:master**.

coveralls commented 2017-03-07 03:27:45 +00:00 (Migrated from github.com)

Copy Link

Changes Unknown when pulling ee97102b54 on jimjin:master into ** on SheetJS:master**.

[](https://coveralls.io/builds/10464203) Changes Unknown when pulling **ee97102b5425b4153b7c41203b5fa3afb2b35f25 on jimjin:master** into ** on SheetJS:master**.

coveralls commented 2017-03-07 03:27:45 +00:00 (Migrated from github.com)

Copy Link

Changes Unknown when pulling ee97102b54 on jimjin:master into ** on SheetJS:master**.

[](https://coveralls.io/builds/10464203) Changes Unknown when pulling **ee97102b5425b4153b7c41203b5fa3afb2b35f25 on jimjin:master** into ** on SheetJS:master**.

coveralls commented 2017-03-07 03:27:45 +00:00 (Migrated from github.com)

Copy Link

Changes Unknown when pulling ee97102b54 on jimjin:master into ** on SheetJS:master**.

[](https://coveralls.io/builds/10464203) Changes Unknown when pulling **ee97102b5425b4153b7c41203b5fa3afb2b35f25 on jimjin:master** into ** on SheetJS:master**.

coveralls commented 2017-03-07 03:27:45 +00:00 (Migrated from github.com)

Copy Link

Changes Unknown when pulling ee97102b54 on jimjin:master into ** on SheetJS:master**.

[](https://coveralls.io/builds/10464203) Changes Unknown when pulling **ee97102b5425b4153b7c41203b5fa3afb2b35f25 on jimjin:master** into ** on SheetJS:master**.

coveralls commented 2017-03-08 05:10:18 +00:00 (Migrated from github.com)

Copy Link

Changes Unknown when pulling ea22b9e2a1 on jimjin:master into ** on SheetJS:master**.

[](https://coveralls.io/builds/10484970) Changes Unknown when pulling **ea22b9e2a1dea4422824ecc1eb1c6c20392874c2 on jimjin:master** into ** on SheetJS:master**.

coveralls commented 2017-03-08 05:10:19 +00:00 (Migrated from github.com)

Copy Link

Changes Unknown when pulling ea22b9e2a1 on jimjin:master into ** on SheetJS:master**.

[](https://coveralls.io/builds/10484970) Changes Unknown when pulling **ea22b9e2a1dea4422824ecc1eb1c6c20392874c2 on jimjin:master** into ** on SheetJS:master**.

pascaldls (Migrated from github.com) approved these changes 2017-03-09 12:55:40 +00:00

SheetJSDev commented 2017-03-23 05:01:01 +00:00 (Migrated from github.com)

Copy Link

I'm going to rework the pull as follows:

• the skipUndefined logic will be the default -- JSON writer generating the "undefined" key is a bug

• the defaultValue parameter will be renamed default. If default is specified, missing data will be given that value. If default is not specified the data will be skipped

Related issues: #582 h/t @jimjin , #147 h/t @jtadmor

I'm going to rework the pull as follows: - the `skipUndefined` logic will be the default -- JSON writer generating the "undefined" key is a bug - the `defaultValue` parameter will be renamed `default`. If `default` is specified, missing data will be given that value. If `default` is not specified the data will be skipped Related issues: #582 h/t @jimjin , #147 h/t @jtadmor

👍 1

SheetJSDev commented 2017-03-23 05:09:08 +00:00 (Migrated from github.com)

Copy Link

On second thought, it's bad to call it default, will stick to defval

On second thought, it's bad to call it `default`, will stick to `defval`

👍 1

Pull request closed

Please reopen this pull request to perform a merge.

Sign in to join this conversation.

Reviewers

No reviewers

pascaldls

Labels

Clear labels   

DBF

  

Dates

  

Defined Names

  

Features

  

Formula

  

HTML

  

Images

  

Infrastructure

  

Integration

  

International

  

ODS

  

Operations

  

Performance

  

PivotTables

  

Pro

  

Protection

  

Read Bug

  

SSF

  

SYLK

  

Style

  

Write Bug

  

good first issue

No Label

DBF

Dates

Defined Names

Features

Formula

HTML

Images

Infrastructure

Integration

International

ODS

Operations

Performance

PivotTables

Pro

Protection

Read Bug

SSF

SYLK

Style

Write Bug

good first issue

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/sheetjs#583

No description provided.