sheetjs/sheetjs
39
Fork 40
Code Issues 195 Pull Requests 12 Wiki Activity

Fix to vbaraw field is null when PartName attribute is /xl/vbaProject.bin #594

Closed
fossamagna wants to merge 1 commits from fix-vbaraw-is-null into master
pull from: fix-vbaraw-is-null
merge into: sheetjs:master
Conversation 5 Commits 1 Files Changed 4 +5 -5
fossamagna commented 2017-03-14 12:10:28 +00:00 (Migrated from github.com)
Copy Link

fix #348

fix #348
coveralls commented 2017-03-14 12:44:07 +00:00 (Migrated from github.com)
Copy Link

Coverage Status

Coverage remained the same at 94.708% when pulling fbb96fec86 on fossamagna:fix-vbaraw-is-null into 7cb978b846 on SheetJS:master.

[![Coverage Status](https://coveralls.io/builds/10582521/badge)](https://coveralls.io/builds/10582521) Coverage remained the same at 94.708% when pulling **fbb96fec8607b7f569ab23f661c5f21f25a39f49 on fossamagna:fix-vbaraw-is-null** into **7cb978b8463cde2da6cd2687cfbcdcf297941c39 on SheetJS:master**.
coveralls commented 2017-03-14 12:44:07 +00:00 (Migrated from github.com)
Copy Link

Coverage Status

Coverage remained the same at 94.708% when pulling fbb96fec86 on fossamagna:fix-vbaraw-is-null into 7cb978b846 on SheetJS:master.

[![Coverage Status](https://coveralls.io/builds/10582521/badge)](https://coveralls.io/builds/10582521) Coverage remained the same at 94.708% when pulling **fbb96fec8607b7f569ab23f661c5f21f25a39f49 on fossamagna:fix-vbaraw-is-null** into **7cb978b8463cde2da6cd2687cfbcdcf297941c39 on SheetJS:master**.
coveralls commented 2017-03-14 12:44:08 +00:00 (Migrated from github.com)
Copy Link

Coverage Status

Coverage remained the same at 94.708% when pulling fbb96fec86 on fossamagna:fix-vbaraw-is-null into 7cb978b846 on SheetJS:master.

[![Coverage Status](https://coveralls.io/builds/10582521/badge)](https://coveralls.io/builds/10582521) Coverage remained the same at 94.708% when pulling **fbb96fec8607b7f569ab23f661c5f21f25a39f49 on fossamagna:fix-vbaraw-is-null** into **7cb978b8463cde2da6cd2687cfbcdcf297941c39 on SheetJS:master**.
coveralls commented 2017-03-14 12:44:08 +00:00 (Migrated from github.com)
Copy Link

Coverage Status

Coverage remained the same at 94.708% when pulling fbb96fec86 on fossamagna:fix-vbaraw-is-null into 7cb978b846 on SheetJS:master.

[![Coverage Status](https://coveralls.io/builds/10582521/badge)](https://coveralls.io/builds/10582521) Coverage remained the same at 94.708% when pulling **fbb96fec8607b7f569ab23f661c5f21f25a39f49 on fossamagna:fix-vbaraw-is-null** into **7cb978b8463cde2da6cd2687cfbcdcf297941c39 on SheetJS:master**.
SheetJSDev commented 2017-03-14 18:50:22 +00:00 (Migrated from github.com)
Copy Link

@fossamagna good catch! Since we're having some issues with travis (there's a 4MB limit to output), we had to change the test suite and rework the commit.

@fossamagna good catch! Since we're having some issues with travis (there's a 4MB limit to output), we had to change the test suite and rework the commit.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
DBF

   
Dates

   
Defined Names

   
Features

   
Formula

   
HTML

   
Images

   
Infrastructure

   
Integration

   
International

   
ODS

   
Operations

   
Performance

   
PivotTables

   
Pro

   
Protection

   
Read Bug

   
SSF

   
SYLK

   
Style

   
Write Bug

   
good first issue
No Label
DBF
Dates
Defined Names
Features
Formula
HTML
Images
Infrastructure
Integration
International
ODS
Operations
Performance
PivotTables
Pro
Protection
Read Bug
SSF
SYLK
Style
Write Bug
good first issue
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/sheetjs#594
No description provided.
Delete Branch "fix-vbaraw-is-null"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?