Support for older browsers #69

2014-06-03T07:22:50Z

altkatz commented

2014-06-03 07:22:50 +00:00

(Migrated from github.com)

tested on IE 8

coveralls commented

2014-06-03 07:35:51 +00:00

(Migrated from github.com)

Coverage remained the same when pulling a27c77ae0e on altkatz:master into 009946339c on SheetJS:master.

[![Coverage Status](https://coveralls.io/builds/828828/badge)](https://coveralls.io/builds/828828) Coverage remained the same when pulling **a27c77ae0ecae60efdefeb4b30d7c01d353e0874 on altkatz:master** into **009946339c6485aa3ebe723debd99df7dfbe649a on SheetJS:master**.

SheetJSDev commented

2014-06-03 07:43:32 +00:00

(Migrated from github.com)

@altkatz thanks for pointing this out! It saddens me to see that jshint doesn't pick up on trailing commas

The gh-pages branch has a shim for IE8 and below which includes what is necessary. That probably should be included in master.

Can you make a few small changes:

remove the trailing comma in the file bits/34_extprops.js -- https://github.com/SheetJS/js-xlsx/blob/master/bits/34_extprops.js#L14
add the file shim.js (from the gh-pages branch) into the master branch (and update the README note to reflect that the shim.js is there)
squash down to one commit.

I will make some more improvements in the next commit that will help prevent this. (I've been playing with https://www.npmjs.org/package/jscs locally and there are configuration options for detecting trailing commas)

@altkatz thanks for pointing this out! It saddens me to see that [jshint doesn't pick up on trailing commas](https://github.com/jshint/jshint/issues/136) The gh-pages branch [has a shim for IE8 and below](https://github.com/SheetJS/js-xlsx/blob/gh-pages/shim.js) which includes what is necessary. That probably should be included in master. Can you make a few small changes: 1) remove the trailing comma in the file bits/34_extprops.js -- https://github.com/SheetJS/js-xlsx/blob/master/bits/34_extprops.js#L14 2) add the file shim.js (from the gh-pages branch) into the master branch (and update the README note to reflect that the shim.js is there) 3) squash down to one commit. I will make some more improvements in the next commit that will help prevent this. (I've been playing with https://www.npmjs.org/package/jscs locally and there are configuration options for detecting trailing commas)

altkatz commented

2014-06-03 08:20:18 +00:00

(Migrated from github.com)

@SheetJSDev shim.js added to master.

coveralls commented

2014-06-03 08:31:50 +00:00

(Migrated from github.com)

Coverage remained the same when pulling 71dd522a2e on altkatz:master into 009946339c on SheetJS:master.

[![Coverage Status](https://coveralls.io/builds/828944/badge)](https://coveralls.io/builds/828944) Coverage remained the same when pulling **71dd522a2ea0d7da5d811900eb1a11d6144bad12 on altkatz:master** into **009946339c6485aa3ebe723debd99df7dfbe649a on SheetJS:master**.

SheetJSDev commented

2014-06-03 15:40:35 +00:00

(Migrated from github.com)

@altkatz thanks for making the changes. If possible, can you squash the three commits down to one ?

SheetJSDev commented

2014-06-03 18:47:53 +00:00

(Migrated from github.com)

@altkatz I went ahead and squashed it. Even though the PR won't show as merged, the commit credits you a96b723cda

@altkatz I went ahead and squashed it. Even though the PR won't show as merged, the commit credits you https://github.com/SheetJS/js-xlsx/commit/a96b723cda6c2adb6c545ddbe0ccbe8a35fd1009

SheetJSDev commented

2014-06-05 14:20:52 +00:00

(Migrated from github.com)

Version 0.7.6 includes the referenced changes