gets Sheet name for multi cell named range, fixes #680
Closedfzumstein wants to merge 1 commits from
Reference in New Issue
There is no content yet.
Delete Branch 'gh-680-multiple-cells-named-range'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Please have a look, this seems to resolve the issue for us.
Do you want us to add a test case or do you prefer to do that yourself?
This doesn't seem to work on all of the files from the test corpus.
After the line in question, add a line that throws an error if the field is missing:
To check against the test corpus, you can run the following command:
WTF=1part throws errors that would otherwise be caught and
FMTS=xlsbrestricts to reading only XLSB files.)
The first fail case is
test_files/2013/apachepoi_50939.xls.xlsb, tripping on the newly-added error.
Hi, sorry for the late reply. I've fixed the commit to fall back again to
It still fails somewhere with the
if(!sname) throw new Error("missing name");line, but that is the same behaviour as on
master, so I don't think that's being caused by my changes.
Let me know know what you think. Thanks!
@SheetJSDev have you been able to look at my fixed commit? see previous comment. thanks for your feedback!
I wasn't saying your commit wasn't useful for your case, but if we're going to change the function processing it's better to fixit in one fell swoop :)
Looked into this a little bit, https://github.com/SheetJS/js-xlsx/issues/680#issuecomment-307869085 was my initial brain dump on the matter.
The XLSB workbook processor is missing a few records like:
After adding some initial implementation, we ran into a few more random cases like https://github.com/SheetJS/test_files/blob/master/2013/apachepoi_ex45978-extraLinkTableSheets.xls.xlsb?raw=true . I suspect the external links files need to be processed.
OK thanks for the feedback!
The particular part was reworked, but you've been credited on a related commit involving incorrect quoting of #REF in an unknown 3d reference.
Step 1:From your project repository, check out a new branch and test the changes.
Step 2:Merge the changes and update on Gitea.