Fix potential infinite loop condition in test suite #735

2017-07-16T21:55:51Z

TeamworkGuy2 commented

2017-07-16 21:55:51 +00:00

(Migrated from github.com)

I was doing some testing with js-xlsx's test suite and ran into a test that was hanging. The problem was cmparr()'s for-loop condition. Switching from != to < fixed the hung test and caused it to error correctly. Thought I'd drop the fix here in-case it's useful to js-xlsx.

I was doing some testing with js-xlsx's test suite and ran into a test that was hanging. The problem was cmparr()'s for-loop condition. Switching from `!=` to `<` fixed the hung test and caused it to error correctly. Thought I'd drop the fix here in-case it's useful to js-xlsx.

SheetJSDev commented

2017-07-19 23:26:06 +00:00

(Migrated from github.com)

Good catch! Out of curiosity, what platform triggered the error?

TeamworkGuy2 commented

2017-07-20 01:25:21 +00:00

(Migrated from github.com)

I made some custom changes to the js-xlsx test suite in relation to a TypeScript project I was working that has some special excel import/export requirements.
The issue doesn't occur in a clean clone of the js-xlsx repository, just related to some custom changes I made that happened to uncover this.

I made some custom changes to the js-xlsx test suite in relation to a TypeScript project I was working that has some special excel import/export requirements. The issue doesn't occur in a clean clone of the js-xlsx repository, just related to some custom changes I made that happened to uncover this.