Prevented crash on wbfactoid #86

2014-07-14T15:29:34Z

lostinplace commented

2014-07-14 15:29:34 +00:00

(Migrated from github.com)

This was causing a crash when xlsb files specified factoids. they're not being parse now, but at least the file gets loaded

coveralls commented

2014-07-14 15:40:36 +00:00

(Migrated from github.com)

Coverage decreased (-0.04%) when pulling 3e475b72c3 on lostinplace:master into 6bc24374b9 on SheetJS:master.

[![Coverage Status](https://coveralls.io/builds/965220/badge)](https://coveralls.io/builds/965220) Coverage decreased (-0.04%) when pulling **3e475b72c381c71cf6494606245ffb4a6feb2cdc on lostinplace:master** into **6bc24374b9f04eb84be848cb9672ed4c2b2aa9f7 on SheetJS:master**.

SheetJSDev commented

2014-07-14 15:49:00 +00:00

(Migrated from github.com)

@lostinplace The fix looks good :) The coverage dropped since none of the test files in https://github.com/SheetJS/test_files had a BrtWbFactoid record. Can you share a file with the record?

lostinplace commented

2014-07-14 15:55:42 +00:00

(Migrated from github.com)

I'll try to track down an example case, right now the only file I have that does this is far too unweildy for a test suite

lostinplace commented

2014-07-14 15:58:38 +00:00

(Migrated from github.com)

Oh God!.... what is the format that you want for the test files?

SheetJSDev commented

2014-07-14 16:09:19 +00:00

(Migrated from github.com)

There is no file too unwieldy for the test suite :) Oftentimes, very specific files have issues that cannot be replicated (saving with excel fixes many problems).

Ideally, I'd like the original XLSB file as well as the file resaved as XLSM (for this library) as well as XLS and XML Spreadsheet 2003 (for https://github.com/SheetJS/js-xls). It would be extremely awesome if you could submit a PR to the test_files repo.

There is no file too unwieldy for the test suite :) Oftentimes, very specific files have issues that cannot be replicated (saving with excel fixes many problems). Ideally, I'd like the original XLSB file as well as the file resaved as XLSM (for this library) as well as XLS and XML Spreadsheet 2003 (for https://github.com/SheetJS/js-xls). It would be extremely awesome if you could submit a PR to the test_files repo.

SheetJSDev commented

2014-07-14 20:42:51 +00:00

(Migrated from github.com)

@lostinplace I merged your commit and added the relevant change to the bits. For some reason the github UI didn't automatically recognize the merge, but it shows up in the commit history.

SheetJSDev commented

2014-07-14 20:52:41 +00:00

(Migrated from github.com)

@lostinplace Generated a test case: https://github.com/SheetJS/test_files/blob/master/smart_tags_2007.xlsb