Fix repeated columns handling in ODS. #179

2015-02-23T11:06:50Z

ziacik commented

2015-02-23 11:06:50 +00:00

(Migrated from github.com)

Hi. Please review the changes I believe fix issue #177
Sorry for not including some unit tests.

Hi. Please review the changes I believe fix issue #177 Sorry for not including some unit tests.

coveralls commented

2015-02-23 11:13:03 +00:00

(Migrated from github.com)

Coverage remained the same at 97.64% when pulling f09ce14636 on ziacik:master into 61b17e6d9d on SheetJS:master.

[![Coverage Status](https://coveralls.io/builds/1977561/badge)](https://coveralls.io/builds/1977561) Coverage remained the same at 97.64% when pulling **f09ce14636b112c84ea4fdc2a4e5640fec3fc066 on ziacik:master** into **61b17e6d9d2544304cff2a57bdac09225360d660 on SheetJS:master**.

SheetJSDev commented

2015-02-23 16:27:34 +00:00

(Migrated from github.com)

@ziacik The cell object q needs to be cloned. Try reading the file and changing one of the repeat values -- you will see that the other cells also change value (the file does not say that the cells are linked, only that they happen to share the same value)

@ziacik The cell object `q` needs to be cloned. Try reading the file and changing one of the repeat values -- you will see that the other cells also change value (the file does not say that the cells are linked, only that they happen to share the same value)

ziacik commented

2015-03-02 12:35:24 +00:00

(Migrated from github.com)

Hi. Added simple cloning of the cell object.

coveralls commented

2015-03-02 12:39:35 +00:00

(Migrated from github.com)

Coverage remained the same at 97.64% when pulling 52a8f7e362 on ziacik:master into 61b17e6d9d on SheetJS:master.

[![Coverage Status](https://coveralls.io/builds/2024357/badge)](https://coveralls.io/builds/2024357) Coverage remained the same at 97.64% when pulling **52a8f7e362ca7d5ed8565158108fe1597e48d96f on ziacik:master** into **61b17e6d9d2544304cff2a57bdac09225360d660 on SheetJS:master**.

coveralls commented

2015-03-02 12:39:35 +00:00

(Migrated from github.com)

Coverage remained the same at 97.64% when pulling 52a8f7e362 on ziacik:master into 61b17e6d9d on SheetJS:master.

[![Coverage Status](https://coveralls.io/builds/2024357/badge)](https://coveralls.io/builds/2024357) Coverage remained the same at 97.64% when pulling **52a8f7e362ca7d5ed8565158108fe1597e48d96f on ziacik:master** into **61b17e6d9d2544304cff2a57bdac09225360d660 on SheetJS:master**.

JavaScriptDude commented

2015-12-18 23:44:34 +00:00

(Migrated from github.com)

I have confirmed that this patch works for my tests