sheetjs/sheetjs
32
Fork 36
Code Issues 193 Pull Requests 12 Wiki Activity

add: unicode test cases for cross-sheet names #2047

Merged
wlawt merged 1 commits from unicode-tests into master 2020-07-05 09:32:28 +00:00
Conversation 2 Commits 1 Files Changed 4 +30
wlawt commented 2020-07-04 02:17:43 +00:00 (Migrated from github.com)
Copy Link

This PR adds additional corner cases tests for unicode names in worksheets being referenced in the same workbook.

All the tests pass in nodejs and (should) with browser (minus the Windows exceptions).

Provides tests for the fix @mohammedsahl added (#2046)

This PR adds additional `corner cases` tests for unicode names in worksheets being referenced in the same workbook. All the tests pass in nodejs and (should) with browser (minus the Windows exceptions). Provides tests for the fix @mohammedsahl added (#2046)
SheetJSDev commented 2020-07-04 02:26:13 +00:00 (Migrated from github.com)
Copy Link

Looks good! Running the browser suite now, @janiewang26 https://app.saucelabs.com/open_sauce/user/sheetjs/tests/vdc shows the tests and https://app.saucelabs.com/open_sauce/user/sheetjs/builds shows the most recently finished builds. Once all the tests pass, merge the changes

Looks good! Running the browser suite now, @janiewang26 https://app.saucelabs.com/open_sauce/user/sheetjs/tests/vdc shows the tests and https://app.saucelabs.com/open_sauce/user/sheetjs/builds shows the most recently finished builds. Once all the tests pass, merge the changes
SheetJSDev commented 2020-07-04 02:34:15 +00:00 (Migrated from github.com)
Copy Link

The travis fails are due to the test_files not having been updated. I can do this after merging

The travis fails are due to the test_files not having been updated. I can do this after merging
👍 1
janiewang26 (Migrated from github.com) approved these changes 2020-07-05 09:30:10 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
janiewang26
Labels
Clear labels   
DBF

   
Dates

   
Defined Names

   
Features

   
Formula

   
HTML

   
Images

   
Infrastructure

   
Integration

   
International

   
ODS

   
Operations

   
Performance

   
PivotTables

   
Pro

   
Protection

   
Read Bug

   
SSF

   
SYLK

   
Style

   
Write Bug

   
good first issue
No Label
DBF
Dates
Defined Names
Features
Formula
HTML
Images
Infrastructure
Integration
International
ODS
Operations
Performance
PivotTables
Pro
Protection
Read Bug
SSF
SYLK
Style
Write Bug
good first issue
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/sheetjs#2047
No description provided.
Delete Branch "unicode-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?